DarkSharpness commented on code in PR #229:
URL: https://github.com/apache/tvm-ffi/pull/229#discussion_r2507002088
##########
include/tvm/ffi/function_details.h:
##########
@@ -64,6 +64,13 @@ template <typename T>
static constexpr bool RetSupported =
(std::is_same_v<T, Any> || std::is_void_v<T> ||
TypeTraits<T>::convert_enabled);
+/// NOTE: we only support `T`, `const T`, `const T&` and `T &&` as argument
types
+template <typename T>
+static constexpr bool TypeSupported =
Review Comment:
Sure. I'm wondering how should we restrict the `ReturnType`. I think for
ref-counted Object type, only returning value type `T` is useful. So we may
only allow value type `T` and `const T` in return type (same as current
implementation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
