On Mon, Mar 3, 2025 at 1:45 PM Rémy Maucherat <r...@apache.org> wrote: > > On Mon, Mar 3, 2025 at 1:27 PM Mark Thomas <ma...@apache.org> wrote: > > > > On 03/03/2025 10:54, Mark Thomas wrote: > > > > <snip/> > > > > > I don't recall if I tested with wine after the changes were complete. I > > > do recall installing and uninstalling wine multiple times. I'll retest > > > now. > > > > So clearly I didn't test this with Wine. There is no way the current > > build.xml file will work with Wine. > > > > The challenge is that the NSIS build now calls out to Ant to sign the > > uninstaller and the installer during the NSIS build. When that happens > > under Wine, it fails for a couple of reasons: > > - Ant isn't on the path > > - Ant depends on Java and there isn't a Windows JRE on the path > > > > The first point is relatively simple to fix. The second starts to make > > this a bit more complex. > > > > An alternative is that Wine can call out to Linux executables but that > > moves the problem to making sure the NSIS build knows whether it is > > running under Windows or Wine. > > I don't think that will work. The best case I managed is that it did > call my "Linux native" Ant, with a Windows path. Meh. Once you get > into the Wine environment, I would say you are stuck in there. > > > Ideally building Tomcat shouldn't be any more complicated than: > > - Install Java > > - Install Ant > > - git checkout ... > > - ant release > > > > Then again, we do require Wine to be installed to do release builds on > > Linux so there are some additional requirements. > > > > I do like the makensis approach as it is a lot simpler. Wine on Mac has > > proven tricky to get working in the past. I can see ythe followuing options: > > > > 1. Remove Wine support. Have ant build makensis to the correct recipe > > when on Linux.
So +1 for 1) since I was able to get it to work and verify 11.0.5. That should mean I can again build the Windows installer properly for 9.0.x. Rémy > Ok. I would like it more if using my platform makensis was possible. I > will be working trying to get a custom makensis this afternoon. > > As it is, Wine suppose is broken, the only way to fix it is to revert > to the way signing was done previously. > > > 2. Add a requirement for a Windows JRE to make a release build and add > > it and Ant to the path when calling the NSIS installer via Wine. > > -1 > No way. > > > 3. Have the NSIS installer call Ant directly on Windows and via Linux > > when running via wine. > > When I run "wine cmd" I get the "Windows" shell, where I can type > commands and see what it is possible to do from there. I think it's > not a good plan. > > > I'm going to start looking at 3 and the building makensis part of 1 and > > see how far I get. > > > > Thoughts? > > Well, the previous way before all of that was working just fine for > me. Other than that, I'll see if I can have 1) work. > > Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
