Rémy,
On 3/3/25 7:45 AM, Rémy Maucherat wrote:
On Mon, Mar 3, 2025 at 1:27 PM Mark Thomas <ma...@apache.org> wrote:
On 03/03/2025 10:54, Mark Thomas wrote:
<snip/>
I don't recall if I tested with wine after the changes were complete. I
do recall installing and uninstalling wine multiple times. I'll retest now.
So clearly I didn't test this with Wine. There is no way the current
build.xml file will work with Wine.
The challenge is that the NSIS build now calls out to Ant to sign the
uninstaller and the installer during the NSIS build. When that happens
under Wine, it fails for a couple of reasons:
- Ant isn't on the path
- Ant depends on Java and there isn't a Windows JRE on the path
The first point is relatively simple to fix. The second starts to make
this a bit more complex.
An alternative is that Wine can call out to Linux executables but that
moves the problem to making sure the NSIS build knows whether it is
running under Windows or Wine.
I don't think that will work. The best case I managed is that it did
call my "Linux native" Ant, with a Windows path. Meh. Once you get
into the Wine environment, I would say you are stuck in there.
Ideally building Tomcat shouldn't be any more complicated than:
- Install Java
- Install Ant
- git checkout ...
- ant release
Then again, we do require Wine to be installed to do release builds on
Linux so there are some additional requirements.
I do like the makensis approach as it is a lot simpler. Wine on Mac has
proven tricky to get working in the past. I can see ythe followuing options:
1. Remove Wine support. Have ant build makensis to the correct recipe
when on Linux.
Ok. I would like it more if using my platform makensis was possible.
+1
Is this the kind of thing we could somehow move upstream? I seem to
recall that the build option we needed to use was just enabling Unicode
support. Do I remember that correctly?
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
