On 03/03/2025 10:54, Mark Thomas wrote:
<snip/>
I don't recall if I tested with wine after the changes were complete. I
do recall installing and uninstalling wine multiple times. I'll retest now.
So clearly I didn't test this with Wine. There is no way the current
build.xml file will work with Wine.
The challenge is that the NSIS build now calls out to Ant to sign the
uninstaller and the installer during the NSIS build. When that happens
under Wine, it fails for a couple of reasons:
- Ant isn't on the path
- Ant depends on Java and there isn't a Windows JRE on the path
The first point is relatively simple to fix. The second starts to make
this a bit more complex.
An alternative is that Wine can call out to Linux executables but that
moves the problem to making sure the NSIS build knows whether it is
running under Windows or Wine.
Ideally building Tomcat shouldn't be any more complicated than:
- Install Java
- Install Ant
- git checkout ...
- ant release
Then again, we do require Wine to be installed to do release builds on
Linux so there are some additional requirements.
I do like the makensis approach as it is a lot simpler. Wine on Mac has
proven tricky to get working in the past. I can see ythe followuing options:
1. Remove Wine support. Have ant build makensis to the correct recipe
when on Linux.
2. Add a requirement for a Windows JRE to make a release build and add
it and Ant to the path when calling the NSIS installer via Wine.
3. Have the NSIS installer call Ant directly on Windows and via Linux
when running via wine.
I'm going to start looking at 3 and the building makensis part of 1 and
see how far I get.
Thoughts?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
