On Sun, Mar 2, 2025 at 5:10 PM Rainer Jung <rainer.j...@kippdata.de> wrote: > > Hi Rémy, > > Am 02.03.25 um 11:06 schrieb Rémy Maucherat: > > On Thu, Feb 13, 2025 at 6:11 PM <ma...@apache.org> wrote: > >> @@ -163,6 +157,9 @@ Var ServiceInstallLog > >> InstType Minimum > >> InstType Full > >> > >> + !finalize 'ant -f @BASEDIR@/build.xml jsign-installer' > >> + !uninstfinalize 'ant -f @BASEDIR@/build.xml > >> -Dcodesigning.file_to_sign=%1 jsign-uninstaller' > > > > This fails for me with Can't recognize xxx as an internal or external > > command, or batch script. > > I tried a few things without much success so far. > > First the original nsi script should automatically be run by ant through > a filter to generate one without @ template strings. Originally the > filter replaced version numbers, but in the new build.xml it also > replaces BASEDIR. The resulting file would be the one used by makensis. > Maybe it makes sense to check, how those lines look like in your > environment in the generated file. > > The other possible problem could be, that ant is not found via PATH. > What is "xxx"? just the full "ant -f ...jsign-installer"? With or > without replaced BASEDIR? What is your platform? Maybe we would have to > change something on Windows?
IMO it simply does not work. If you run on Wine, then you're inside a fake Windows env, not the original platform. So if you try to run the "ant" command in there, it might simply fail and there's no way at all to do it. It does the same for installer and uninstaller, the issue is with running command "ant". Was this retested with Wine ? It seems the 10.1 tag is bad too so I'm likely not the only one having an issue. Installing makensis worked (installing it was annoying since the Fedora packaging was messy - probably it can be installed without distro packaging). So if that's "ok", then you should remove the Wine support since there are only 2-3 users for this. Rémy > Thanks and regards, > > Rainer > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
