Costin Manolache wrote:
"slow" usually requires a context - i.e. server type, memory, CPU,
expected load.
And beeing 'fastest' is not allways the most important thing for
everyone - fastest jsp won't help if it OOM or if other components get
less memory.
Footprint is as important as well.
The is the sort of design decisions and resultant performance that was
in Tomcat 3.0's JSP and which gave Tomcat a bad name for *years*. Since
it's all in the name of helping this one user and his nice 300MB of
JSPs, it is not a good move, even if optional.
- it adds complexity
- it will create additional code generation paths that will not be
tested (as usual)
Almost every feature will add some complexity, and will be tested by
the subset of people who need it ( example: the apr library :-)
Actually, this is false. Countless features stopped working one day
after their initial submission because there was casual interest in
them, and only a handful of users (which never upgraded) were using
them. This is definitely the case here, and overall, this makes Tomcat
lower quality.
- I contend that in 2006 it is useless
It is useless for people who run huge servers and can fit everything in memory.
It is not useless for people who have lots of JSPs or run on shared memory.
I know you are not going to give up.
I feel strongly about this issue because I am concerned with using
tomcat in lower memory environments ( not only my extreme case, but
also on 'regular' computers where tomcat is not the center of the
universe and can't take all the memory ). Remy is obviously concerned
about big server case where performance is a very important issue.
Having a flag can do both cases - except that the code is already
complex, so it's better to be worth it. Of course, if the patch is
also cleaning up jspservlet and makes it easy - that won't be an issue
:-)
The problem is that the issues you care about have caused some trouble
lately, so I don't feel very compelled to follow your opinions on this one.
We all cause some troubles from time to time, and tend to value our own opinions
a bit high. Luckily - this is not about following my opinion or my
troubles - it's about
a tomcat feature. The fact that it's useless for yourself, or that 3.3
was slow, or that adding any code increases complexity and testing are
not IMO valid reasons to veto.
Sorry, but I have a perfectly valid reason to give a -1. It's very
simple from my perspective anyway: I will make sure I will not be using
patches such as this one, and so I will maintain my own Jasper branch
(as I am doing for the rest of the container).
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
