Well, it the patch is based on unloading the JSP - it won't be easy, the -1 that Remy expressed initially seems valid ( and all it takes to make it valid is a second comitter, which I just did ). So according to the rules it won't work - and even if it would work, it may still cause unexpected breakage of applications which is bad.
If it externalizes the strings - I don't see what valid veto can be raised, we did this in the past ( 3.3 - not complete ). It would also help to have some simple 'ab' tests to show how much is lost in raw performance - it's allways a tradeoff between memory and disk, and a lot of applications work just fine without keeping all in memory - but it's good to know numbers instead of talking about our assumptions. I feel strongly about this issue because I am concerned with using tomcat in lower memory environments ( not only my extreme case, but also on 'regular' computers where tomcat is not the center of the universe and can't take all the memory ). Remy is obviously concerned about big server case where performance is a very important issue. Having a flag can do both cases - except that the code is already complex, so it's better to be worth it. Of course, if the patch is also cleaning up jspservlet and makes it easy - that won't be an issue :-) Costin On 3/7/06, Yoav Shapira <[EMAIL PROTECTED]> wrote: > Hola, > Let's all try to stay professional. > > Yaroslav or whomever else is interested: if you can produce a patch that > > (a) Can be turned on or off > (b) Is set to off by default, so current behavior is unmodified unless > the user turns it on > (c) Doesn't harm anything else > (d) Comes with a test case that shows it doesn't harm anything else > > Then I'm sure you can get 3 +1 votes and have the patch incorporated. > > Yoav > > On 3/7/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: > > S. Dierkes wrote: > > > If you're still searching for a real world application: we have an > > > application where JSP's are generated dynamically from database (no > > > on-the-fly because to time consuming, so they are created offline), > > > currently there had been ~1500 JSP's (~100MB) created (plus the > > > application > > > itself). The application creates JSP and PDF of real-world forms (fill in > > > as > > > html, print out as pdf) for different customers (mainly banks), so the > > > jsp-base is constantly increasing. > > > > Lol, that's really pathetic ... > > > > Rémy > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > Yoav Shapira > Senior Architect > Nimalex LLC > 1 Mifflin Place, Suite 310 > Cambridge, MA, USA > [EMAIL PROTECTED] / www.yoavshapira.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
