+1 for PRs in Github - one place, simple On Wed, Jun 14, 2017 at 9:17 AM, Kenneth Howe <kh...@pivotal.io> wrote:
> -1 per my comments on the [DISCUSS] thread > > > On Jun 11, 2017, at 9:51 AM, Jacob Barrett <jbarr...@pivotal.io> wrote: > > > > After a few days of discussion [1] this thread has quieted down so I > would > > like to take it to a vote. The proposal is to modify the workflow of > > committers to match that of non-committers such that committers shall: > > > > * Perform all work in progress on branches in their personal forks on > > GitHub rather than directly on the ASF Geode repositories. > > > > * Submit GitHub pull requests, following all current rules for pull > > requests, for changes that would require peer review before committing to > > the production branches. > > > > * Register their GitHub accounts with the ASF so that committers can be > > identified in the GitHub mirror repositories. > > > > > > Please cast your vote. > > > > [ ] +1 Approve > > [ ] +0 No opinion > > [ ] -1 Disapprove (and reason why) > > > > > > [1] [DISCUSS] Using Pull Requests over Review Board > > <http://geode.markmail.org/message/row5hgz5zw2ooadl?q= > list:org%2Eapache%2Egeode%2Edev+discuss+pull> > > > > -Jake > >
