----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59404/#review175732 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java Line 251 (original), 253 (patched) <https://reviews.apache.org/r/59404/#comment249087> Do we need to assert here or do as in following logic (line#263): if (lr.isUsedForPartitionedRegionBucket()) It looks like, this could be called for non-pr bucket region...Where is the recordEvent set for non bucket region. geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java Lines 543 (patched) <https://reviews.apache.org/r/59404/#comment249088> instead of instance check we could use region.isUsedForPartitionedRegionBucket() Is this needs to be in for loop...Or can this be moved after for loop under if (this.gotImage()) geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java Lines 546 (patched) <https://reviews.apache.org/r/59404/#comment249091> Sorry for nit picking... will it be more readble to switch the condition... if (providerEfventStates != null) { set } else { log } geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java Lines 556 (patched) <https://reviews.apache.org/r/59404/#comment249090> It will be cleaner to have this in BucketRegion where the map is created. getRemoteEventStates() clearRemoteEventStates() - anilkumar gingade On May 19, 2017, 3:38 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59404/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 3:38 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-2939 > https://issues.apache.org/jira/browse/GEODE-2939 > > > Repository: geode > > > Description > ------- > > Event tracker initilization for bucket region is delayed until after GII, and > will be initialized from the GII provider. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java > 886d678 > > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java > c1d1e77 > geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java > 2c86aed > > geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java > fb5f0cf > > geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java > 3faf41f > > > Diff: https://reviews.apache.org/r/59404/diff/1/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
