> On May 23, 2017, 12:34 a.m., anilkumar gingade wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java > > Line 251 (original), 253 (patched) > > <https://reviews.apache.org/r/59404/diff/1/?file=1725072#file1725072line256> > > > > Do we need to assert here or do as in following logic (line#263): > > if (lr.isUsedForPartitionedRegionBucket()) > > > > It looks like, this could be called for non-pr bucket region...Where is > > the recordEvent set for non bucket region.
Only BucketRegion sends event states back in CreateRegionReplyMessage, this assert is to alert future changes if any. But it is no longer needed as it is handled in the BucketRegion now. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59404/#review175732 ----------------------------------------------------------- On May 19, 2017, 3:38 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59404/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 3:38 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-2939 > https://issues.apache.org/jira/browse/GEODE-2939 > > > Repository: geode > > > Description > ------- > > Event tracker initilization for bucket region is delayed until after GII, and > will be initialized from the GII provider. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java > 886d678 > > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java > c1d1e77 > geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java > 2c86aed > > geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java > fb5f0cf > > geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java > 3faf41f > > > Diff: https://reviews.apache.org/r/59404/diff/1/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
