----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59404/#review175956 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java Lines 293 (patched) <https://reviews.apache.org/r/59404/#comment249293> Can this method ever be invoked concurrently by two different threads? geode-core/src/main/java/org/apache/geode/internal/cache/CacheDistributionAdvisee.java Lines 60 (patched) <https://reviews.apache.org/r/59404/#comment249303> Change this comment to not talk about BucketRegion. You can do that down on BucketRegion override of this method if needed. Here I would just say something like: Allows this advisee to know the CreateRegionReplyProcessor that is creating it. geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java Lines 209 (patched) <https://reviews.apache.org/r/59404/#comment249305> Why is this Map <?,?> ? I can see on EventTracker.recordState we have: Map<ThreadIdentifier, EventSeqnoHolder> But then on LocalRegion.recordEventState we just have "Map". Would it be hard to fix this to consistently use Map<ThreadIdentifier, EventSeqnoHolder>? geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java Line 259 (original), 255 (patched) <https://reviews.apache.org/r/59404/#comment249307> I'm not sure why we bother nulling out reply.eventState but at the very least this line should be moved into the if (rely.eventState != null) - Darrel Schneider On May 23, 2017, 3:32 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59404/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 3:32 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-2939 > https://issues.apache.org/jira/browse/GEODE-2939 > > > Repository: geode > > > Description > ------- > > Event tracker initilization for bucket region is delayed until after GII, and > will be initialized from the GII provider. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java > 886d678 > > geode-core/src/main/java/org/apache/geode/internal/cache/CacheDistributionAdvisee.java > e4a7957 > > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java > c1d1e77 > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java > 485835b > geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java > 2c86aed > > geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java > fb5f0cf > > geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java > 3faf41f > > > Diff: https://reviews.apache.org/r/59404/diff/3/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
