Looks like our log files in the end, still print out the geode log levels
like "fine" for "debug", "error" for "fatal". This is because when
developer wrote
"logger.debug("message")" in their code, the appender we used will
internally convert that log message to print out "fine" instead of
"debug". So even though we use log4J internally, on the outside, users
still sees the geode custom levels in the log file.
Should we go ahead and change the log file to the regular log levels and
work towards getting rid of a log of our log* code?
On Thu, Mar 16, 2017 at 2:31 PM, Darrel Schneider <dschnei...@pivotal.io>
wrote:
> Since we have trace for finer and finest I think all is well.
>
> On Thu, Mar 16, 2017 at 1:38 PM, Kirk Lund <kl...@apache.org> wrote:
>
> > That's correct. I flipped mine around half way down the list. I love to
> > delete the old LogWriter log levels to eliminate this confusion...
> >
> >
> > On Thu, Mar 16, 2017 at 1:12 PM, Jinmei Liao <jil...@pivotal.io> wrote:
> >
> > > I believe this is the mapping:
> > >
> > > LogWriter Log4J2
> > > ---------------------------------------
> > > SEVERE = FATAL
> > > ERROR = ERROR
> > > WARNING = WARN
> > > INFO, CONFIG = INFO
> > > FINE = DEBUG
> > > FINER, FINEST = TRACE
> > >
> > > We do have a lot of code that still uses the LogWriter.
> > >
> > > On Thu, Mar 16, 2017 at 10:29 AM, Kirk Lund <kl...@apache.org> wrote:
> > >
> > > > Here's the equivalent log levels between LogWriter levels and Log4J2
> > > levels
> > > >
> > > > LogWriter Log4J2
> > > > ------------------------
> > > > SEVERE = FATAL
> > > > ERROR = ERROR
> > > > WARN = WARNING
> > > > INFO = INFO, CONFIG
> > > > DEBUG = FINE
> > > > TRACE = FINER, FINEST
> > > >
> > > > On Thu, Mar 16, 2017 at 10:08 AM, Darrel Schneider <
> > > dschnei...@pivotal.io>
> > > > wrote:
> > > >
> > > > > My understanding is the geode fine, finer, finest all map to log4j
> > > debug.
> > > > > If we get rid of the geode levels would all three fine* levels be
> > > enabled
> > > > > when the log level is debug?
> > > > > If so this might be a problem because finest can be way too much.
> > > > >
> > > > > I think geode's config and info both map to log4j info and I'm find
> > > with
> > > > > info logging both config and info.
> > > > >
> > > > >
> > > > > On Wed, Mar 15, 2017 at 11:31 AM, Swapnil Bawaskar <
> > > sbawas...@pivotal.io
> > > > >
> > > > > wrote:
> > > > >
> > > > > > +1 to making the change and updating the docs to reflect only the
> > new
> > > > log
> > > > > > levels.
> > > > > >
> > > > > > On Wed, Mar 15, 2017 at 10:45 AM Jinmei Liao <jil...@pivotal.io>
> > > > wrote:
> > > > > >
> > > > > > > Hi, all,
> > > > > > >
> > > > > > > Geode, before using log4j for logging has implemented its own
> > > > > LogWriters
> > > > > > > and logLevels. Geode log levels has values like "finest, finer,
> > > fine,
> > > > > > > config, info, warning, error, severe". We've moved away from
> > using
> > > > > these
> > > > > > > log writers to favor using log4j logging. So, mostly, geode
> logs
> > > have
> > > > > > log4j
> > > > > > > log statements with levels like "fatal, error, warn, info,
> > debug".
> > > > > > >
> > > > > > > But by examining our existing commands that has log-level
> > options,
> > > > > > > specifically "start server", "start locator", "alter runtime",
> > > > "change
> > > > > > > log-level", these commands are still accepting log-levels with
> > > geode
> > > > > log
> > > > > > > levels, and under the cover, it has a mapping to the log4j
> > levels.
> > > > > Since
> > > > > > we
> > > > > > > are moving away from geode's own logging, I would like to
> propose
> > > > > > changing
> > > > > > > these commands to use log4j log levels explicitly.
> > > > > > >
> > > > > > > To avoid breaking existing commands, we can provide a mapping
> to
> > > the
> > > > > > log4j
> > > > > > > levels after user provides an "old" log level, but at least I
> > would
> > > > > like
> > > > > > to
> > > > > > > have the auto complete start showing the log4j levels instead
> of
> > > the
> > > > > > geode
> > > > > > > log levels and move towards getting rid of these old levels
> > > > completely.
> > > > > > >
> > > > > > > --
> > > > > > > Cheers
> > > > > > >
> > > > > > > Jinmei
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Cheers
> > >
> > > Jinmei
> > >
> >
>
--
Cheers
Jinmei
