Do we still have lots of code that is deciding whether or not to log based on finest, finer and fine, etc?
-- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: +1-631-835-4771 On Thu, Mar 16, 2017 at 1:08 PM, Darrel Schneider <dschnei...@pivotal.io> wrote: > My understanding is the geode fine, finer, finest all map to log4j debug. > If we get rid of the geode levels would all three fine* levels be enabled > when the log level is debug? > If so this might be a problem because finest can be way too much. > > I think geode's config and info both map to log4j info and I'm find with > info logging both config and info. > > > On Wed, Mar 15, 2017 at 11:31 AM, Swapnil Bawaskar <sbawas...@pivotal.io> > wrote: > > > +1 to making the change and updating the docs to reflect only the new log > > levels. > > > > On Wed, Mar 15, 2017 at 10:45 AM Jinmei Liao <jil...@pivotal.io> wrote: > > > > > Hi, all, > > > > > > Geode, before using log4j for logging has implemented its own > LogWriters > > > and logLevels. Geode log levels has values like "finest, finer, fine, > > > config, info, warning, error, severe". We've moved away from using > these > > > log writers to favor using log4j logging. So, mostly, geode logs have > > log4j > > > log statements with levels like "fatal, error, warn, info, debug". > > > > > > But by examining our existing commands that has log-level options, > > > specifically "start server", "start locator", "alter runtime", "change > > > log-level", these commands are still accepting log-levels with geode > log > > > levels, and under the cover, it has a mapping to the log4j levels. > Since > > we > > > are moving away from geode's own logging, I would like to propose > > changing > > > these commands to use log4j log levels explicitly. > > > > > > To avoid breaking existing commands, we can provide a mapping to the > > log4j > > > levels after user provides an "old" log level, but at least I would > like > > to > > > have the auto complete start showing the log4j levels instead of the > > geode > > > log levels and move towards getting rid of these old levels completely. > > > > > > -- > > > Cheers > > > > > > Jinmei > > > > > >
