On Tue, Sep 26, 2017 at 6:45 PM, Nicholas Hurley <hur...@mozilla.com> wrote:
> So I'm going to chime in on a formatting discussion for probably the second > time in my life as a mozillian. (It's apparently that important to me.) > > On Tue, Sep 26, 2017 at 9:25 AM, Mats Palmgren <m...@mozilla.com> wrote: > > > 2. touching more lines than necessary when adding/removing params, > > making it harder to follow blame links > > > > Judging from my personal use of blame links, it's very rare that > > I want to find when a specific param was added to a signature. > > This is also something that tooling could solve (skip blame on > > lines that differ only by whitespace). > > > > This is probably half the time I annotate something (I refuse to use the b > word here). Use cases differ, and for a lot of what I find myself doing, > this would make it demonstrably worse. > Mercurial and Git both support a -w argument to ignore whitespace with annotate/blame. In addition, modern versions of Mercurial have `hg annotate --skip <revset>` which allows you to specify a revset used to select revisions to skip over when annotating. The Chromium developer tools have git-hyper-blame ( https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html), which is similar. What both tools seem to lack is the ability to toggle whitespace and revision skipping via the web interface. This can certainly be implemented. Also, revision skipping is not an exact science and the results may not match expectations, so it shouldn't be seen as a cure-all. > > > > I think improved readability trumps all of the minor issues above. > > > > Readability is (to an extent) in the eye of the beholder. For example, I > have a difficult time following long gaps in things... so vertically > aligned parameters, where one of them has an extra-long type name (which > also seems to happen a lot in things I'm working with) become exceedingly > difficult for me to match type and name quickly. (Yes, there are editor > tricks to help with this, and yes I use them, but they still only get me so > far when I'm quickly scanning code). > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
