>On 8/31/17 6:50 PM, Ehsan Akhgari wrote: >> On 08/30/2017 09:03 PM, Eric Rahm wrote: >>> Okay sounds like there's agreement on a). >> >> Indeed. I have edited the Style Guide to reflect this. > >Fwiw, I disagree with this decision. > >Here's a more realistic example of *actual use* from our code base: >http://searchfox.org/mozilla-central/rev/d29c832536839b60a9ee5b512eeb934274b879b0/layout/forms/nsFormControlFrame.h#57-64 > >This example shows that it's easier to read arguments at a glance >when they are aligned, IMO.
I agree with Mats here - it's easier to read, specifically in the case where you have a large number of args, especially of widely varying type-lengths. Obviously, one could disagree, but that's a good example. -- Randell Jesup, Mozilla Corp remove "news" for personal email _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
