On Wed, Aug 30, 2017 at 1:21 AM, Sylvestre Ledru <sle...@mozilla.com> wrote:
> > Le 30/08/2017 à 08:53, Henri Sivonen a écrit : > > Regardless of the outcome of this particular style issue, where are we > > in terms of clang-formatting all the non-third-party C++ in the tree? > > We have been working on that but we delayed it to avoid doing it during > the 57 work. > > We will share more news about that soon. > This is probably obvious, but there are chunks of non-third-party C++ in the tree that follow other styles (e.g., media/mtransport is Google style guide style) so please be careful not to reformat those. -Ekr > > I've had a couple of cases of late where the initializers in a > > pre-existing constructor didn't follow our style, so when I changed > > the list a tiny bit, the post-clang-format patch showed the whole list > > as changed (due to any change to the list triggering reformatting the > > whole thing to our style). I think it would be better for productivity > > not to have to explain artifacts of clang-format during review, and at > > this point the way to avoid it would be to make sure the base revision > > is already clang-formatted. > > > Could you report a bug? We wrote a few patches upstream to improve > the support of our coding style. > > > Thanks, > Sylvestre > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
