On Wed, Aug 30, 2017 at 10:21 AM, Sylvestre Ledru <sle...@mozilla.com> wrote: > > Le 30/08/2017 à 08:53, Henri Sivonen a écrit : > > Regardless of the outcome of this particular style issue, where are we > in terms of clang-formatting all the non-third-party C++ in the tree? > > We have been working on that but we delayed it to avoid doing it during the > 57 work. > > We will share more news about that soon.
Cool. Thanks. > I've had a couple of cases of late where the initializers in a > pre-existing constructor didn't follow our style, so when I changed > the list a tiny bit, the post-clang-format patch showed the whole list > as changed (due to any change to the list triggering reformatting the > whole thing to our style). I think it would be better for productivity > not to have to explain artifacts of clang-format during review, and at > this point the way to avoid it would be to make sure the base revision > is already clang-formatted. > > Could you report a bug? We wrote a few patches upstream to improve > the support of our coding style. It's not a bug: The constructors were not formatted according to our style to begin with, so an edit triggered clang-format formatting them to our style. -- Henri Sivonen hsivo...@hsivonen.fi https://hsivonen.fi/ _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
