On Mon, Apr 17, 2017 at 09:34:39PM -0400, Ben Kelly wrote: > On Mon, Apr 17, 2017 at 9:21 PM, Nicholas Nethercote <n.netherc...@gmail.com > > wrote: > > > > That is why we have links to the bug. Bug should always be the unite of > > > truth telling > > > why some change was done. Bugs tend to have so much more context about > > the > > > change than any individual commit message can or should have. > > > > With all due respect, I think you have a different view on this to at least > > some people (and perhaps most people). > > > > FWIW I agree with Olli. I look for a good one line summary of the change, > but beyond that I find you really do need to look at the bug to get the > full context. > > I don't object to people writing longer commit messages, but that > information needs to be in the bug. Our tools today (splinter and > mozreview) don't do that automatically AFAIK.
FWIW, I find this behavior of mozreview to be irritating. The commit message are send in bugmail, but they are hidden in UI (although you can unhide them). I can understand how multiple iterations of the patches would leave multiple comments with essentially the same content, but the opposite lack of anything displayed by default is also annoying. > I think there is an hg extension you can get to do it with splinter. Most things that attach patches automatically do that AFAIK. Obviously, when you attach patches manually, it's up to you. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
