On Tue, Apr 18, 2017 at 9:58 AM, smaug <sm...@welho.com> wrote: > > That is why we have links to the bug. Bug should always be the unite of > truth telling > why some change was done. Bugs tend to have so much more context about the > change than any individual commit message can or should have. >
With all due respect, I think you have a different view on this to at least some people (and perhaps most people). In a recent similar dev-platform thread you said the following: "In practice I tend to just read the first line of a commit message and the most important part there is the bug number." I was genuinely surprised to read that. Like bz and gps, I strongly prefer getting context from commit messages than from bug reports. I appreciate informative commit messages. I put effort into writing them myself, and I would expect a reviewer to read them given that they are intended to make their life easier. Obviously, conciseness is also desired, but I prefer commit messages that err on the side of too much detail rather than not enough. (In general, IME the two main ways a patch author can help a reviewer are (a) write small patches, and (b) write good commit messages.) Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
