On 4/17/17 10:45 PM, Jim Blandy wrote:
It seems like there is actually not a consensus on this. (I had thought Smaug's view was the consensus, and found bz's post surprising.)
Really? I know where Olli is coming from, but even in his view a commit message like the one I was talking about is not OK, I'm pretty sure.
And note that in this case the bug had no useful information either, for what it's worth.
But for the record, I disagree with Olli, precisely because of long and hence unreadable bugs. If your commit message _can_ reasonably distill a long bug discussion, then I think it should.
If this is worth settling
For what it's worth, I don't think we need the "should the commit message describe all the context?" discussion settled just to settle the question of whether the commit message should _add_ anything to the commit other than the bug number. Especially when the bug doesn't explain the purpose of the commit either!
For the overall question here, I agree that we're not going to get anywhere in a mailing list discussion. ;)
-Boris _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
