On Mon, Apr 17, 2017 at 10:36 PM, Steve Fink <sf...@mozilla.com> wrote:
> On 04/17/2017 08:11 PM, Nicholas Nethercote wrote: > >> On Tue, Apr 18, 2017 at 11:34 AM, Ben Kelly <bke...@mozilla.com> wrote: >> >> I don't object to people writing longer commit messages, but that >>> information needs to be in the bug. Our tools today (splinter and >>> mozreview) don't do that automatically AFAIK. I think there is an hg >>> extension you can get to do it with splinter. >>> >>> Yes, 'hg bzexport' defaults to copying the commit message into a bug >> comment. >> > > Heh. Yes, bzexport will copy the commit message into a comment. 1 point in > its favor. > MozReview does exactly the same thing. But Bugzilla appears to hide comments with the "mozreview-request" tag by default in the web UI. The full commit message / attachment description comes across in the HTML email, however. This seems like behavior that could be revisited if a bug were filed with a compelling reason for the change. > > If you use it to create bugs (via the --new flag), it will use the first > line of the commit message as the default bug title. Which goes against > what has been repeatedly requested in this thread, in that the bug title is > what is wrong, the commit message is what is being done to fix it. 1 point > against. (Though arguably this is ok for feature request bugs.) > FWIW GitHub pull requests have the same problem. There is an inherent UX design conflict between lowering the barrier to task completion [with metadata that's "good enough"] versus asking the user to do too much in the name of being ideal. In both cases, the tools are forcing the existence of a "named grouping" (via a bug or pull request title/summary) onto end-users. You can't argue too hard with that: summaries are convenient for dashboards and tables. My personal opinion is the tools should optimize for "throwing code over the wall" to get one step closer to landing and minimize abandonment. So default heuristics for picking the summary feel like a lesser evil than requiring the user to explicitly enter something. And this is exactly what `hg bzexport --new` and GitHub's web UI for new pull requests do by defaulting to the commit message for titles. > > (bzexport was also written in the mq era and has some deficiencies when > using it with a more modern workflow. It's fixable, but it needs some work.) > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
