You shouldn't need to annotate the file/line separately, because that is (or at least should be!) the top of the stack.
FWIW, we are currently working on changing the signature for crashes with an AbortMessage (those using NS_RUNTIMEABORT) so that the abort message is part of the signature. After that works, we should probably do the same thing or something similar for the new MozCrashReason field. (I'm not sure why we used different field names for these.) --BDS On Tue, May 31, 2016 at 9:18 AM, Gabriele Svelto <gsve...@mozilla.com> wrote: > On 31/05/2016 13:26, Gijs Kruitbosch wrote: > > We could do a find/replace of no-arg calls to a new macro that uses > > MOZ_CRASH with a boilerplate message, and make the argument non-optional > > for new uses of MOZ_CRASH? That would avoid the problem for new > > MOZ_CRASH() additions, which seems like it would be wise so the problem > > doesn't get worse? Or is it not worth even that? > > What about adding file/line number information? This way one could > always tell where it's coming from even if it doesn't have a descriptive > string. > > Gabriele > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
