On Tue, May 31, 2016 at 5:06 PM, Chris Peterson <cpeter...@mozilla.com> wrote: >> >> #2 is unannotated MOZ_CRASH() calls, i.e. there is no string argument >> given. These are mostly OOMs, though there are a few others in there. >> These ones should be annotated so they show up separately. > > MOZ_CRASH()'s explanation string parameter is optional. Should it be > required? There are 998 calls in mozilla-central to MOZ_CRASH() without an > argument, so annotating all of these won't happen overnight.
Doesn't seem worthwhile. Annotating the one in NS_ABORT_OOM() will cover the vast majority of the cases, and annotating (or fixing) a handful more cases will get us almost all of the others. Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
