We considered that for the graphics ones, but the line number doesn’t persist between versions, so we weren’t sure how the search would find all the ones that are the same, but on different line numbers in different versions. In the end we settled on using unique strings (for the interesting ones, at least.) — - Milan
> On May 31, 2016, at 9:18 , Gabriele Svelto <gsve...@mozilla.com> wrote: > > On 31/05/2016 13:26, Gijs Kruitbosch wrote: >> We could do a find/replace of no-arg calls to a new macro that uses >> MOZ_CRASH with a boilerplate message, and make the argument non-optional >> for new uses of MOZ_CRASH? That would avoid the problem for new >> MOZ_CRASH() additions, which seems like it would be wise so the problem >> doesn't get worse? Or is it not worth even that? > > What about adding file/line number information? This way one could > always tell where it's coming from even if it doesn't have a descriptive > string. > > Gabriele > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
