On 2015-06-04 6:07 AM, David Rajchenbach-Teller wrote:
Part of my world domination plans are to turn warnings into something that causes test to actually fail (see bug 1080457 & co). Would you like to join forces?
There are very good reasons for warnings to not cause tests to fail. We have a lot of tests that are testing failure conditions that are expected to warn, because they are failure conditions.
In my experience, in some cases where we have a particularly spammy warning, the underlying reason is that there is an error condition that we know how to handle properly, but we still warn about it. Or alternatively, there are warnings which indicate that the author of the code did not think at the time that can happen, but a lot of them can be ignored.
There are also warnings that were actually meant to be assertions, and we should try to convert them to assertions, and that way they will fail tests. That being said, assertion report stack traces in debug builds, which is excruciatingly slow, so we have had to switch them to be warnings in at least some cases (see bug 756045 for example.)
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
