On 2015-06-04 5:49 AM, Jonas Sicking wrote:
FWIW, I suspect it'll be hard to put a dent in the number of warnings that we emit unless we either change all instances of NS_ENSURE_SUCCESS(rv, rv) to use some other macro which doesn't warn, or unless we change NS_ENSURE_SUCCESS(rv, rv) to not warn.
Do we really have to do that? It seems like all we need to do is to investigate the highly occurring warnings and silence them somehow. NS_ENSURE_SUCCESS warning is super useful when debugging things such as intermittent test failures, or big complicated web pages that are triggering an issue somehow -- they can often give you a starting point on where you need to look.
It feels like right now we have three incompatible desires: * Test lots of failure cases. * Make errors warn in debug builds on all/most frames as the failure is propagated up the callstack. * Don't warn a lot when testing debug builds. It seems like we can only pick two out of these three.
It seems to me that if we change #3 to mean fixing highly frequently occurring warnings, we can have all three of the above together.
_______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
