On 2015/06/04 21:38, Robert O'Callahan wrote:
Usually I use NS_WARNING to mean "something weird and unexpected is
happening, e.g. a bug in Web page code, but not necessarily a browser bug".
Sometimes I get useful hints from NS_WARNING spew leading up to a serious
failure, but for those usages could probably be switched to PR_LOG without
losing much.
Rob
After coping with voluminous messages in C-C TB |make mozmill| test
suite log [much smaller volume than full FF logs],
I think we should have NS_INFORMATION() macro that
prints out an information for someone who is developing code and
just wants to know how the code is doing.
So many "WARNING" lines such as the ones below can be turned into
INFORMATION messages and we can probably ignore these lines from NG/GO
decisions of tests.
Hmm. The particular log I picked from two months ago is not
quite representative. I specifically excluded NS_ENSURE_TRUE summary
from below, but for this particular log, the messages near the top of
list (decreasing frequency order) seem too serious to be INFORMATION kind.
> WARNING: Allow one letter C/c as language code.:
The above line below is from my own attempt to
make C-C TB accpet C.UTF-8 as locale: I think cygwin's default locale is
this. But mozilla code refuses to accept this claiming that the first
part of the locale needs to be either two or three letters.
And I used dreaded NS_WARNING() instead of something better: if
NS_INFORMATION() is there, I will use it.
--- begin quote ---
Second without NS_ENSURE macros:
Count/sum is modulo [without the first PID]
1576 [10262] WARNING: '!mMainThread', file
/REF-COMM-CENTRAL/comm-central/mozilla/xpcom/threads/nsThreadManager.cpp, line
395
868 [10262] WARNING: Failed to retarget HTML data delivery to the
parser thread.: file
/REF-COMM-CENTRAL/comm-central/mozilla/parser/html/nsHtml5StreamParser.cpp,
line 951
693 [10262] WARNING: Subdocument container has no frame: file
/REF-COMM-CENTRAL/comm-central/mozilla/layout/base/nsDocumentViewer.cpp,
line 2511
100 [21074] WARNING: We should have hit the document element...:
file /REF-COMM-CENTRAL/comm-central/mozilla/layout/xul/BoxObject.cpp,
line 183
58 [10262] WARNING: unable to post continuation event: file
/REF-COMM-CENTRAL/comm-central/mozilla/xpcom/io/nsStreamUtils.cpp, line 453
58 [10262] WARNING: An event was posted to a thread that will
never run it (rejected): file
/REF-COMM-CENTRAL/comm-central/mozilla/xpcom/threads/nsThread.cpp, line 505
45 [10553] WARNING: No inner window available!: file
/REF-COMM-CENTRAL/comm-central/mozilla/dom/base/nsGlobalWindow.cpp, line
9658
36 [10262] WARNING: Re-registering a CID?: file
/REF-COMM-CENTRAL/comm-central/mozilla/xpcom/components/nsComponentManager.cpp,
line 531
36 [10262] WARNING: Hardware Vsync support not yet implemented.
Falling back to software timers
36 [10262] WARNING: Failed to open external DTD: publicId
"-//W3C//DTD SVG 1.1//EN" systemId
"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"; base
"file:///REF-COMM-CENTRAL/comm-central/mail/themes/linux/mail/tabs/selected-start.svg"
URL "resource://gre/res/dtd/svg11.dtd": file
/REF-COMM-CENTRAL/comm-central/mozilla/parser/htmlparser/nsExpatDriver.cpp,
line 703
36 [10262] WARNING: Failed to open external DTD: publicId
"-//W3C//DTD SVG 1.1//EN" systemId
"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"; base
"file:///REF-COMM-CENTRAL/comm-central/mail/themes/linux/mail/tabs/selected-end.svg"
URL "resource://gre/res/dtd/svg11.dtd": file
/REF-COMM-CENTRAL/comm-central/mozilla/parser/htmlparser/nsExpatDriver.cpp,
line 703
36 [10262] WARNING: Allow one letter C/c as language code.: file
/REF-COMM-CENTRAL/comm-central/mozilla/intl/locale/unix/nsPosixLocale.cpp,
line 128
35 [10262] WARNING: unable to Flush() dirty datasource during
XPCOM shutdown: file
/REF-COMM-CENTRAL/comm-central/mozilla/rdf/base/nsRDFXMLDataSource.cpp,
line 754
35 WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and
everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS!
32 [21074] WARNING: Must complete empty transaction when
compositing!: file
/REF-COMM-CENTRAL/comm-central/mozilla/layout/base/nsPresShell.cpp, line
6257
30 [21074] WARNING: Someone passed native anonymous content
directly into frame construction. Stop doing that!: file
/REF-COMM-CENTRAL/comm-central/mozilla/layout/base/nsCSSFrameConstructor.cpp,
line 6550
28 [21074] WARNING: nsMsgProtocol::SetContentCharset() not
implemented: file
/REF-COMM-CENTRAL/comm-central/mailnews/base/util/nsMsgProtocol.cpp,
line 580
20 [21074] WARNING: anonymous nodes should not be in child lists
(bug 439258): file
/REF-COMM-CENTRAL/comm-central/mozilla/layout/base/RestyleManager.cpp,
line 1441
18 [8115] WARNING: There is no observer for "invalidformsubmit".
One should be implemented!: file
/REF-COMM-CENTRAL/comm-central/mozilla/dom/html/HTMLFormElement.cpp,
line 2005
17 [10262] WARNING: some msg dbs left open: '!m_dbCache.Length()',
file
/REF-COMM-CENTRAL/comm-central/mailnews/db/msgdb/src/nsMsgDatabase.cpp,
line 85
11 [10262] WARNING: Failed to open external DTD: publicId
"-//W3C//DTD SVG 1.1//EN" systemId
"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"; base
"file:///REF-COMM-CENTRAL/comm-central/mail/themes/linux/mail/tabs/closeTab.svg"
URL "resource://gre/res/dtd/svg11.dtd": file
/REF-COMM-CENTRAL/comm-central/mozilla/parser/htmlparser/nsExpatDriver.cpp,
line 703
10 [24607] WARNING: XPCOM objects created/destroyed from static
ctor/dtor: file
/REF-COMM-CENTRAL/comm-central/mozilla/xpcom/base/nsTraceRefcnt.cpp,
line 132
6 [8115] WARNING: cannot SetMetaDataElement: 'NS_SUCCEEDED(rv)',
file /REF-COMM-CENTRAL/comm-central/mozilla/dom/html/nsHTMLDocument.cpp,
line 765
....
---- end quote ---
Anyway, I agree that we should simply try to attack the top entries
first to figure out whether they are indication of genuine issues/bugs, etc.
Eventually we could cut down the number to manageable size.
(At near the beginning of 2013, the list became only about a dozen items
long, but started to grow again. In a sense it reflects the desire of
code authors to catch strange conditions, but I agree we must keep on
looking at the logs and do something about the top offenders in the log
list.)
TIA
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
