On Thu, Jun 4, 2015 at 2:49 AM, Jonas Sicking <[email protected]> wrote:
> FWIW, I suspect it'll be hard to put a dent in the number of warnings > that we emit unless we either change all instances of > NS_ENSURE_SUCCESS(rv, rv) to use some other macro which doesn't warn, > or unless we change NS_ENSURE_SUCCESS(rv, rv) to not warn. > As you can see the from the list, the distribution of these warnings is very uneven. It is not necessary to solve the entire warning issue to make huge reductions in the total volume of warnings we see. For instance, in bug 1170642 I noticed that there were about 16MB of warnings in e10s M2, produced by a single line of code (which Eric fixed by removing the warning). Andrew > It feels like right now we have three incompatible desires: > > * Test lots of failure cases. > * Make errors warn in debug builds on all/most frames as the failure > is propagated up the callstack. > * Don't warn a lot when testing debug builds. > > It seems like we can only pick two out of these three. > > / Jonas > > > > On Wed, Jun 3, 2015 at 6:14 PM, Eric Rahm <[email protected]> wrote: > > We emit a *lot* of runtime warnings when running debug tests. I > inadvertently triggered a max log size failure during a landing this week > which encouraged me to take a look at what all is being logged, and what I > found was a ton of warnings (sometimes accompanied by stack traces). Most > of these should probably be removed (of course if they're real issues they > should be fixed, but judging by the frequency most are probably non-issues). > > > > I'm currently cleaning up some of these, but if you happen to see > something in the following list and are feeling proactive I would > appreciate the help. There's even a meta bug for tracking these: > https://bugzilla.mozilla.org/show_bug.cgi?id=765224 > > > > I generated this list by grabbing the logs for a recent m-c linux64 > debug run, normalizing out PIDs and timestamps and then doing some > sort/uniq-fu to get counts of unique lines. > > > > This is roughly the top 40 offenders: > > > > 65959 [NNNNN] WARNING: Overflowed nscoord_MAX in conversion to > nscoord width: file ../../dist/include/nsRect.h, line 83 > > 63460 [NNNNN] WARNING: NS_ENSURE_TRUE(piTarget) failed: file > gdom/events/EventDispatcher.cpp, line 469 > > 20039 [NNNNN] WARNING: 'NS_FAILED(rv)', file > gdom/workers/ServiceWorkerManager.cpp, line 2529 > > 20039 [NNNNN] WARNING: > '!BasePrincipal::IsCodebasePrincipal(aPrincipal)', file > gdom/workers/ServiceWorkerManager.cpp, line 2591 > > 17784 [NNNNN] WARNING: Subdocument container has no frame: file > glayout/base/nsDocumentViewer.cpp, line 2506 > > 16322 JavaScript warning: > file:///builds/slave/test/build/tests/jsreftest/tests/js1_8/extensions/regress-476427.js, > line 1: JavaScript 1.6's for-each-in loops are deprecated; consider using > ES6 for-of instead > > 14159 [NNNNN] WARNING: NS_ENSURE_TRUE(mMutable) failed: file > gnetwerk/base/nsSimpleURI.cpp, line 264 > > 14087 [NNNNN] WARNING: NS_ENSURE_SUCCESS(EnsureScriptEnvironment(), > nullptr) failed with result 0x80040111: file gdocshell/base/nsDocShell.cpp, > line 4592 > > 11315 [NNNNN] WARNING: '!mMainThread', file > gxpcom/threads/nsThreadManager.cpp, line 299 > > 10574 [NNNNN] WARNING: No docshells for remote frames!: file > gdom/base/nsFrameLoader.cpp, line 491 > > 9201 [NNNNN] WARNING: have unconstrained width; this should only > result from very large sizes, not attempts at intrinsic width calculation: > 'psd->mIEnd != NS_UNCONSTRAINEDSIZE', file > glayout/generic/nsLineLayout.cpp, line 884 > > 9155 [NNNNN] WARNING: have unconstrained width; this should only > result from very large sizes, not attempts at intrinsic width calculation: > 'psd->mIEnd != NS_UNCONSTRAINEDSIZE', file > glayout/generic/nsLineLayout.cpp, line 3058 > > 9130 [NNNNN] WARNING: have unconstrained width; this should only > result from very large sizes, not attempts at intrinsic width calculation: > 'aISize != NS_UNCONSTRAINEDSIZE', file glayout/generic/nsLineLayout.cpp, > line 160 > > 8844 [NNNNN] WARNING: Someone passed native anonymous content > directly into frame construction. Stop doing that!: file > glayout/base/nsCSSFrameConstructor.cpp, line 6559 > > 7599 [NNNNN] WARNING: NS_ENSURE_TRUE(mDocShell) failed: file > gembedding/browser/nsWebBrowser.cpp, line 363 > > 7454 [NNNNN] WARNING: anonymous nodes should not be in child lists > (bug 439258): file glayout/base/RestyleManager.cpp, line 1440 > > 6544 [NNNNN] WARNING: Graph thread slowdown?: > 'std::abs(framePosition - CurrentDriver()->StateComputedTime()) < > MillisecondsToMediaTime(5)', file gdom/media/MediaStreamGraph.cpp, line 1195 > > 6126 [NNNNN] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result > 0x80520012: file gnetwerk/base/nsFileStreams.cpp, line 492 > > 6126 [NNNNN] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result > 0x80520012: file gnetwerk/base/nsFileStreams.cpp, line 205 > > 5637 [NNNNN] WARNING: No outer window available!: file > gdom/base/nsGlobalWindow.cpp, line 3915 > > 5109 [NNNNN] WARNING: NS_ENSURE_TRUE(domWindow) failed: file > gembedding/browser/nsDocShellTreeOwner.cpp, line 83 > > 5085 [NNNNN] WARNING: NS_ENSURE_TRUE(aInBrowser) failed: file > gembedding/browser/nsDocShellTreeOwner.cpp, line 79 > > 4856 [NNNNN] WARNING: zero axis length: file > gdom/svg/nsSVGLength2.cpp, line 124 > > 4708 [NNNNN] WARNING: Shouldn't call SchedulePaint in a detached > pres context: file glayout/generic/nsFrame.cpp, line 5181 > > 4051 [NNNNN] WARNING: have unconstrained inline-size; this should > only result from very large sizes, not attempts at intrinsic inline-size > calculation: '(mFrameType == NS_CSS_FRAME_TYPE_INLINE && > !frame->IsFrameOfType(nsIFrame::eReplaced)) || type == nsGkAtoms::textFrame > || ComputedISize() != NS_UNCONSTRAINEDSIZE', file > glayout/generic/nsHTMLReflowState.cpp, line 448 > > 4050 [NNNNN] WARNING: have unconstrained inline-size; this should > only result from very large sizes, not attempts at intrinsic inline-size > calculation: 'AvailableISize() != NS_UNCONSTRAINEDSIZE', file > glayout/generic/nsHTMLReflowState.cpp, line 360 > > 3897 [NNNNN] WARNING: have unconstrained width; this should only > result from very large sizes, not attempts at intrinsic width calculation: > 'NS_UNCONSTRAINEDSIZE != aReflowState.ComputedISize()', file > glayout/generic/nsBlockReflowState.cpp, line 118 > > 3892 [NNNNN] WARNING: have unconstrained inline-size; this should > only result from very large sizes, not attempts at intrinsic inline-size > calculation: 'NS_UNCONSTRAINEDSIZE != computedISizeCBWM && > NS_UNCONSTRAINEDSIZE != availISizeCBWM', file > glayout/generic/nsHTMLReflowState.cpp, line 2398 > > 3581 [NNNNN] WARNING: Please do not use mouseenter/leave events in > chrome. They are slower than mouseover/out!: > '!nsContentUtils::IsChromeDoc(d)', file > gdom/events/EventListenerManager.cpp, line 367 > > 3452 [NNNNN] WARNING: NS_ENSURE_TRUE(textComposition) failed: file > gwidget/PuppetWidget.cpp, line 729 > > > > And the overall log sizes (~218M total): > > > > 31M > mozilla-central_ubuntu64_vm-debug_test-crashtest-bm122-tests1-linux64-build17.txt > > 20M > mozilla-central_ubuntu64_vm-debug_test-jsreftest-bm113-tests1-linux64-build5.txt > > 13M > mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm51-tests1-linux64-build1.txt > > 12M > mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm114-tests1-linux64-build2.txt > > 12M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm118-tests1-linux64-build42.txt > > 11M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm116-tests1-linux64-build10.txt > > 10M > mozilla-central_ubuntu64_vm-debug_test-mochitest-3-bm52-tests1-linux64-build21.txt > > 8.7M > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm67-tests1-linux64-build0.txt > > 8.0M > mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm113-tests1-linux64-build3.txt > > 7.5M > mozilla-central_ubuntu64_vm-debug_test-reftest-1-bm117-tests1-linux64-build2.txt > > 7.2M > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-2-bm122-tests1-linux64-build18.txt > > 5.9M > mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm121-tests1-linux64-build0.txt > > 5.4M > mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm120-tests1-linux64-build5.txt > > 5.2M > mozilla-central_ubuntu64_vm-debug_test-reftest-2-bm53-tests1-linux64-build17.txt > > 5.1M > mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm121-tests1-linux64-build18.txt > > 5.0M > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-3-bm114-tests1-linux64-build0.txt > > 5.0M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm67-tests1-linux64-build15.txt > > 4.8M > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm51-tests1-linux64-build9.txt > > 4.8M > mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm52-tests1-linux64-build0.txt > > 4.6M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm51-tests1-linux64-build22.txt > > 4.2M > mozilla-central_ubuntu64_vm-debug_test-cppunit-bm113-tests1-linux64-build9.txt > > 3.5M > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm120-tests1-linux64-build4.txt > > 3.1M > mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm114-tests1-linux64-build5.txt > > 2.9M > mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm122-tests1-linux64-build0.txt > > 2.8M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm51-tests1-linux64-build52.txt > > 2.6M > mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm118-tests1-linux64-build37.txt > > 2.4M > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-4-bm118-tests1-linux64-build6.txt > > 2.4M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm118-tests1-linux64-build21.txt > > 2.0M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm117-tests1-linux64-build5.txt > > 2.0M > mozilla-central_ubuntu64_vm-debug_test-jittest-1-bm123-tests1-linux64-build2.txt > > 2.0M > mozilla-central_ubuntu64_vm-debug_test-jittest-2-bm116-tests1-linux64-build4.txt > > 1.8M > mozilla-central_ubuntu64_vm-debug_test-mochitest-gl-bm118-tests1-linux64-build29.txt > > 1.7M > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm51-tests1-linux64-build7.txt > > 1.4M > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm117-tests1-linux64-build5.txt > > 552K > mozilla-central_ubuntu64_vm-debug_test-xpcshell-bm67-tests1-linux64-build1.txt > > 288K > mozilla-central_ubuntu64_vm-debug_test-marionette-bm118-tests1-linux64-build8.txt > > 188K > mozilla-central_ubuntu64_vm-debug_test-mochitest-push-bm53-tests1-linux64-build13.txt > > > > _______________________________________________ > > dev-platform mailing list > > [email protected] > > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ > dev-platform mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
