On 11/02/2012 01:47 AM, Dave Mandelin wrote:
First, I want to try to pour some gasoline on the dying embers and
suggest that perhaps we should totally rearrange everything. As a
developer user of our testing systems, I always found it incredibly
irritating that there were test directories sprinkled throughout the
tree that got copied to the build dirs as part of the build process,
with no clear mapping between the build path of the test, the source
path of the test, and the path you had to pass to mochitests to
actually run the test.

This, at least, is easily solved: even today, you can run ./mach mochitest-plain foo/bar/test_baz.html and never again care about what happens in the build dir. (Yes, mach doesn't yet accept all options the python harness itself supports; patches welcome.)


I would prefer something like this:

|-- tests/
         |-- browser-chrome/
                 |-- topic1 (omit this level if there would be only one)
                 |-- topic2
                 |-- [...]
         |-- chrome/
         |-- crashtests/
         |-- marionette/
         |-- mochitests/
         |-- reftests/
         |-- xpcshell
         |-- [..]/

This seems to suggest moving tests as far away from the code they test as possible; I don't think that's a sensible thing to do. If I'm working on, say content/html/content/src/nsHTMLInputElement.cpp, the most relevant tests are easily found in content/html/content/test/forms/. I don't see what benefit it would bring to put them further away.

HTH
Ms2ger

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to