On 06/02/2010 03:45 AM, Jari Aalto wrote:
The log entry is written wrong. Unfortunately the messages was mistakenly left
in the changelog. Please disregard.
The changelog is documentation for the package. I can't just disregard
it. The wrong changelog has so far cost several people time discussing
it, and who knows how much more time it will cost others. It must be
revised in a new upload.
-1.1 as it does not have the bad nvidia-glx dep.
Put the dependency back to the way it was before
You clipped some *vital* context here to understand what I'm talking about:
I said: "Huh? Maybe the patch for -2 superceded -1.1 as it does not
have the bad nvidia-glx dep."
The *-1.1 NMU's Build-Depends is the same as it was in *-1, so this is
in order.
It is not in order. Your debian/patches directory includes a patch that
has the bad dep. My "Huh?" was surprise that the current debian/control
does not have the bad dep even though it is included in the patches! I
postulated that your bad patch series was the reason for this (i.e. "two
wrongs make a right" :)
fix the bad patch series, make sure the new version (-1.2) is *fully*
tested, and re-upload.
Please clarify the "bad patch series", as I don't understand how to
interpret it, and I'll take a look. The changelog reads:
xpilot-ng (1:4.7.3-1.1) unstable; urgency=low
xpilot-ng (1:4.7.3-1) unstable; urgency=low
xpilot-ng (1:4.7.3~cvs20091102-1) unstable; urgency=low
...
The NMU was fully tested under pbuilder before upload.
Look at debian/patches for yourself and you will see what I mean:
sy...@lear:~/downloads/xpilot-ng-4.7.3$ ls debian/patches/
debian-changes-1:4.7.3-1.1 debian-changes-1:4.7.3-2 series
sy...@lear:~/downloads/xpilot-ng-4.7.3$ cat debian/patches/series
debian-changes-1:4.7.3-2
debian-changes-1:4.7.3-1.1
sy...@lear:~/downloads/xpilot-ng-4.7.3$ grep ', nvidia-glx-dev'
debian/patches/*
debian/patches/debian-changes-1:4.7.3-1.1:++Build-Depends: autoconf,
automake1.11, debhelper (>= 7.1), libx11-dev, libxext-dev,
x11proto-core-dev, zlib1g-dev, libexpat1-dev, libsdl1.2-dev,
libsdl-image1.2-dev, libsdl-ttf2.0-dev, libalut-dev, libopenal-dev (>=
1:1.10.622), help2man, python-support, nvidia-glx-dev
The patches are a total mess. We have a spurious -2 patch, apparently
applied in *reverse order*, the -1.1 patch includes the bad
nvidia-glx-dev dep, and yet somehow the final packaging doesn't include
this dependency! So I don't really know what to make of it.
Please fix!
Ben
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
