Hi Sean, Sean Whitton <spwhit...@spwhitton.name> writes:
> Hello Xiyue, > > Thanks. I think you sent the wrong patches Oops, sorry. > but I had a look at your > branch on salsa. This still isn't quite what I mean. I think that > > - you should be using the Emacs built binary (as you are now doing) > - we should not commit the file emacs-common-substvars to git. > Instead it should be generated during the build. > > So the main thing missing is that the generating of the file should be > incorporated into the build. Probably it should go into the existing > override_dh_auto_install. > I understand that this file is mostly useful during package building. Still, I'd like to give another try to propose to have debian/emacs-common-substvars committed in git: this will help with debugging in the following scenarios: * When we want to understand why some packages are (or not) being replaces by Emacs, and * When we want to see what packages are updated between Emacs releases (which is also why I put a package+version per line in the comments). Without this file, we need to get this information from `apt show' or from https://packages.debian.org/ which would be very cumbersome and hard to get it right. Wdyt? > -- > Sean Whitton -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
