Sean Whitton <spwhit...@spwhitton.name> writes: > Hello Xiyue, > > This is great work. Thank you for the respin. I'd just like to ask a > few questions about it. > > - What is the emacs-provided-package-versions variable for? I don't > think it gets set anywhere? >
It's used later in the `emacs-provided-package-versions` function, which will populate it with a mapping of package name to version. This will then be used later to actually generate the substvars values. > - Why pregenerate emacs-common-substvars? I put the list of package and version provides in comments in this file so that we can keep track of package addition and version change on each Emacs update easier. The actual substvars list everything in one line so it's harder to check for diff. > Why not generate it during the build using the version of Emacs we > just built? > It also gets regenerated with `debian/rules debian-sync': notice that the build rule is marked `.PHONY'. I think this should be run on each update according to d/README.source. Maybe this could be added to dh_auto_clean in case someone (like me) forgets to run it by hand? > -- > Sean Whitton -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
