Hello,

On Wed 16 Jul 2025 at 10:30am -07, Xiyue Deng wrote:

> Sean Whitton <spwhit...@spwhitton.name> writes:
>
>> Hello Xiyue,
>>
>> This is great work.  Thank you for the respin.  I'd just like to ask a
>> few questions about it.
>>
>> - What is the emacs-provided-package-versions variable for?  I don't
>>   think it gets set anywhere?
>>
>
> It's used later in the `emacs-provided-package-versions` function, which
> will populate it with a mapping of package name to version.  This will
> then be used later to actually generate the substvars values.

I don't think it needs to be a defvar.  It can be a lexical variable
inside that function.

> It also gets regenerated with `debian/rules debian-sync': notice that
> the build rule is marked `.PHONY'.  I think this should be run on each
> update according to d/README.source.  Maybe this could be added to
> dh_auto_clean in case someone (like me) forgets to run it by hand?

Why not generate it during the build?  That's how other substvars work.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to