Hi Paul, On 23.05.2017 at 20:27 wrote Paul Gevers: > On 23-05-17 11:04, Joerg Steffens wrote: >>> Great. Except that because dbconfig is implemented in sh, you need to >>> check the exit value of every command line (and no, set -e doesn't >>> guarantee that already; that is why all these "|| return $?" are there). >> >> I see. However, the only lines where this might make sense are: >> tsubstfile=$(dbc_mktemp) >> /usr/sbin/dbconfig-generate-include -f template -o >> template_infile=$sqlfile $dbc_packageconfig > $tsubstfile > > Indeed. > >> I can add it there, however, similar lines at other places of the code >> are also without "|| return $?". > > Hmm, than that may be a bug. Which lines do you have in mind?
These lines are used 4 times in dpkg/postinst: 2 times for install, 2 times added by me for updates. None of them have the "|| return $?". Once more it is used in dpkg/prerm (not affected by my patch). >> Should I add these lines and sent the patch again? > > Trivial of course, not needed. Thanks. regards, Jörg -- Jörg Steffens joerg.steff...@bareos.com Bareos GmbH & Co. KG Phone: +49 221 630693-91 http://www.bareos.com Fax: +49 221 630693-10 Sitz der Gesellschaft: Köln | Amtsgericht Köln: HRA 29646 Komplementär: Bareos Verwaltungs-GmbH Geschäftsführer: S. Dühr, M. Außendorf, Jörg Steffens, P. Storz
signature.asc
Description: OpenPGP digital signature
