Hi Jörg, On 22-05-17 20:46, Jörg Steffens wrote: > we are using dbconfig-common for packaging Bareos.
Great. > It would help us, if dbconfig-common would also evaluate the > dbc_sql_substitution setting on upgrades, not only on installs. Sounds good (without any investigation on my part) > A patch for this functionality is included. Great. Except that because dbconfig is implemented in sh, you need to check the exit value of every command line (and no, set -e doesn't guarantee that already; that is why all these "|| return $?" are there). > If you decide *NOT* to include it, please update the documentation for > dbc_sql_substitution, so people get aware, that this behavior is intended. Will do, but I expect that won't be needed. > My current workaround is to run scripts/upgrade/NUMBER, which uses dbconfig- > generate-include to create data/upgrade-dbadmin/NUMBER. Looks ugly. > Of course, this requires that dbconfig-common continues to executes upgrades > in > this order (scripts/upgrade, data/upgrade-dbadmin, data/upgrade), which is not > guranteed. Please consider to keep this order, as we use build Bareos also for > older distributions (Debian 7, Ubuntu 12.04). I should probably document the order. I think multiple things are relying on it albeit the documentation says it can change. Paul
signature.asc
Description: OpenPGP digital signature
