Hi Paul, On 22.05.2017 at 21:43 wrote Paul Gevers: [...] >> A patch for this functionality is included. > > Great. Except that because dbconfig is implemented in sh, you need to > check the exit value of every command line (and no, set -e doesn't > guarantee that already; that is why all these "|| return $?" are there).
I see. However, the only lines where this might make sense are:
tsubstfile=$(dbc_mktemp)
/usr/sbin/dbconfig-generate-include -f template -o
template_infile=$sqlfile $dbc_packageconfig > $tsubstfile
I can add it there, however, similar lines at other places of the code
are also without "|| return $?".
Should I add these lines and sent the patch again?
>> If you decide *NOT* to include it, please update the documentation for
>> dbc_sql_substitution, so people get aware, that this behavior is intended.
>
> Will do, but I expect that won't be needed.
>
>> My current workaround is to run scripts/upgrade/NUMBER, which uses dbconfig-
>> generate-include to create data/upgrade-dbadmin/NUMBER.
>
> Looks ugly.
Indeed.
>> Of course, this requires that dbconfig-common continues to executes upgrades
>> in
>> this order (scripts/upgrade, data/upgrade-dbadmin, data/upgrade), which is
>> not
>> guranteed. Please consider to keep this order, as we use build Bareos also
>> for
>> older distributions (Debian 7, Ubuntu 12.04).
>
> I should probably document the order.
Excellent.
One other question:
is there a mailing list to discuss about dbconfig-common?
Jörg
--
Jörg Steffens joerg.steff...@bareos.com
Bareos GmbH & Co. KG Phone: +49 221 630693-91
http://www.bareos.com Fax: +49 221 630693-10
Sitz der Gesellschaft: Köln | Amtsgericht Köln: HRA 29646
Komplementär: Bareos Verwaltungs-GmbH
Geschäftsführer:
S. Dühr, M. Außendorf, Jörg Steffens, P. Storz
signature.asc
Description: OpenPGP digital signature
