Hi Jörg,

On 23-05-17 11:04, Joerg Steffens wrote:
>> Great. Except that because dbconfig is implemented in sh, you need to
>> check the exit value of every command line (and no, set -e doesn't
>> guarantee that already; that is why all these "|| return $?" are there).
> 
> I see. However, the only lines where this might make sense are:
>             tsubstfile=$(dbc_mktemp)
>             /usr/sbin/dbconfig-generate-include -f template -o
> template_infile=$sqlfile $dbc_packageconfig > $tsubstfile

Indeed.

> I can add it there, however, similar lines at other places of the code
> are also without "|| return $?".

Hmm, than that may be a bug. Which lines do you have in mind?

> Should I add these lines and sent the patch again?

Trivial of course, not needed.

> One other question:
> is there a mailing list to discuss about dbconfig-common?

Yes, except that the list¹ doesn't have an active admin. I requested to
be assigned admin rights in the past, but until now I've never had a
response. Also, since I took over the dbconfig package, I haven't seen
anybody responding to queries other than me.

Paul

¹
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/dbconfig-common-devel

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to