On Wed, 23 Jul 2025 06:50:50 GMT, Alan Bateman <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback changes.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 106:
>
>> 104: *
>> 105: * <p>This is the expected was to open an {@code ImageReader}, and
>> it should
>> 106: * be rare for anything other than the native byte order to be
>> needed.
>
> I think the "Almost all callers" and "This is the expected was (typo)"
> comments are confusing. Can we remove these?
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2247989719
