On Wed, 23 Jul 2025 07:00:35 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback changes.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 138:
>
>> 136: * @param name a JRT file system name (path) of the form
>> 137: * {@code "/modules/<module>/...} or {@code
>> "/packages/<package>/...}.
>> 138: * @return a node representing a resource, directory or symbolic
>> link.
>
> This is the jimage reader rather than the jrt file system so it's very
> confusing to see comments about "JRT file system" in this file.
This class is *almost* only here for building JrtFileSystem. Everything else is
marginal usage. Hence, admitting that in these docs felt reasonable to me. I
think it would be bad if someone reading the docs in this class didn't know
that there's a strong reason for the namespace unification. I can reframe it to
talk-around the fact this is all ultimately for file-system like semantics
without naming JrtFileSystem, but they are extremely closely coupled in terms
of usage.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2231614903
