On Fri, 25 Jul 2025 17:09:30 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> This class is *almost* only here for building JrtFileSystem. Everything else >> is marginal usage. Hence, admitting that in these docs felt reasonable to >> me. I think it would be bad if someone reading the docs in this class didn't >> know that there's a strong reason for the namespace unification. I can >> reframe it to talk-around the fact this is all ultimately for file-system >> like semantics without naming JrtFileSystem, but they are extremely closely >> coupled in terms of usage. > > It should be possible to move jrtfs to its own module, say jdk.jrtfs. It does > not need to be in the base module. My comments are only to ensure that we > keep the architectural boundaries clean. Also, the line: "is used internally in the JDK to implement jimage/jrtfs access" is just below so it's not the first admission that this is aligned closely with JrtFileSystem. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2231652596
