[ 
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346081#comment-14346081
 ] 

Yongjun Zhang commented on HADOOP-9477:
---------------------------------------

HI [~dapengsun],

Really sorry for getting back late.

Thanks for addressing my earlier comments. I did another round of review, the 
patch looks pretty good, one suggestion is to consolidate TestLdapGroupsMapping 
 and TestLdapGroupsMappingWithPosixGroup, by refactoring the shared code to a 
common parent class.

{quote}
Good suggestion, it will be an improvement to check the configuration. Not only 
for posix, but also for normal ldap model. Do you think it is possible to let 
me file another jira to fix it.
{quote}
I think it's ok to have a follow-up jira for the checking.

BTW, I also invited [~atm] to help looking at the patch from his perspective, 
thanks ATM.

Thanks.


> posixGroups support for LDAP groups mapping service
> ---------------------------------------------------
>
>                 Key: HADOOP-9477
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9477
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.4-alpha
>            Reporter: Kai Zheng
>            Assignee: Dapeng Sun
>             Fix For: 2.7.0
>
>         Attachments: HADOOP-9477.003.patch, HADOOP-9477.004.patch, 
> HADOOP-9477.005.patch, HADOOP-9477.006.patch, HADOOP-9477.patch, 
> HADOOP-9477.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> It would be nice to support posixGroups for LdapGroupsMapping service. Below 
> is from current description for the provider:
> hadoop.security.group.mapping.ldap.search.filter.group:
> An additional filter to use when searching for LDAP groups. This should be
> changed when resolving groups against a non-Active Directory installation.
> posixGroups are currently not a supported group class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to