[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322546#comment-14322546
]
Dapeng Sun commented on HADOOP-9477:
------------------------------------
Hi Yongjun
Thank you very much for your comments, really sorry for late reply.
{quote}When isPosix is true, is it an error if any of gitAttribute and
uidAttribute is null? or this is a valid scenario (in this case, no group will
be found for the user)?{quote}
Good suggestion, it will be an improvement to check the configuration. Not only
for posix, but also for normal ldap model. Do you think it is possible to let
me file another jira to fix it.
{quote}change "POSIX_GIDNUMBER" to " POSIX_GIDNUMBER" (add a space to be
consistent){quote}
Good suggestion, I will fix it in next patch.
{quote}Line 371 you added to assign isPosix exceed 80 characters (some other
lines that you did not touch in this file also exceeds 80 chars, up to you
whether to fix all of them together or defer to later).{quote}
Yes, some code in this file even exceed 100 characters. These should be fixed.
I will fix my new lines in next patch, do you think it is possible to let me
file another jira to fix others.
{quote}Have you got chance to test it out in a real environment?{quote}
Yes, I created the posix user\group example in a real ldap environment, the
Unit test is also created based on it.
{quote} why public static final String POSIX_USER = "posixAccount"; is not
public static final String POSIX_USER = "posixUser";?{quote}
I will rename {{POSIX_USER}} to {{POSIX_ACCOUNT}} in next patch since
{{posixAccount}} is on LDAP specification and we may can't change it.
http://docs.oracle.com/cd/E19693-01/819-0986/6n3chgmli/index.html#NAME . Thank
again for your good suggestion.
Regards
Dapeng
> posixGroups support for LDAP groups mapping service
> ---------------------------------------------------
>
> Key: HADOOP-9477
> URL: https://issues.apache.org/jira/browse/HADOOP-9477
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.4-alpha
> Reporter: Kai Zheng
> Assignee: Dapeng Sun
> Fix For: 2.7.0
>
> Attachments: HADOOP-9477.003.patch, HADOOP-9477.004.patch,
> HADOOP-9477.005.patch, HADOOP-9477.patch, HADOOP-9477.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> It would be nice to support posixGroups for LdapGroupsMapping service. Below
> is from current description for the provider:
> hadoop.security.group.mapping.ldap.search.filter.group:
> An additional filter to use when searching for LDAP groups. This should be
> changed when resolving groups against a non-Active Directory installation.
> posixGroups are currently not a supported group class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
