[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318507#comment-14318507
]
Yongjun Zhang commented on HADOOP-9477:
---------------------------------------
Hi [~drankye], [~dapengsun] and [~clamb],
Thanks for the help to push this forward!
I review the patch, it looks good. I have one minor nit:
The check of the code below
{code}
if (groupSearchFilter.contains(POSIX_GROUP)
&& userSearchFilter.contains(POSIX_USER)) {
{code}
can be replaced with a boolean variable to be set right after we do
{code}
groupSearchFilter =
conf.get(GROUP_SEARCH_FILTER_KEY, GROUP_SEARCH_FILTER_DEFAULT);
userSearchFilter =
conf.get(USER_SEARCH_FILTER_KEY, USER_SEARCH_FILTER_DEFAULT);
{code}
in {{setConf(Configuration conf)}}, so we don't have to do the {{contains}}
checking each time when {{doGetGroups}} is called.
Thanks.
> posixGroups support for LDAP groups mapping service
> ---------------------------------------------------
>
> Key: HADOOP-9477
> URL: https://issues.apache.org/jira/browse/HADOOP-9477
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.4-alpha
> Reporter: Kai Zheng
> Assignee: Dapeng Sun
> Fix For: 2.7.0
>
> Attachments: HADOOP-9477.003.patch, HADOOP-9477.004.patch,
> HADOOP-9477.patch, HADOOP-9477.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> It would be nice to support posixGroups for LdapGroupsMapping service. Below
> is from current description for the provider:
> hadoop.security.group.mapping.ldap.search.filter.group:
> An additional filter to use when searching for LDAP groups. This should be
> changed when resolving groups against a non-Active Directory installation.
> posixGroups are currently not a supported group class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
