[
https://issues.apache.org/jira/browse/HADOOP-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320606#comment-14320606
]
Yongjun Zhang commented on HADOOP-9477:
---------------------------------------
HI [~dapengsun],
Thanks for the new rev. I have a question and couple of nits that you can defer
to later when taking care of other review comments.
* When isPosix is true, is it an error if any of gitAttribute and uidAttribute
is null? or this is a valid scenario (in this case, no group will be found for
the user)?
* change "+POSIX_GIDNUMBER" to "+ POSIX_GIDNUMBER" (add a space to be
consistent)
* Line 371 you added to assign isPosix exceed 80 characters (some other lines
that you did not touch in this file also exceeds 80 chars, up to you whether to
fix all of them together or defer to later).
BTW, Have you got chance to test it out in a real environment?
Thanks.
> posixGroups support for LDAP groups mapping service
> ---------------------------------------------------
>
> Key: HADOOP-9477
> URL: https://issues.apache.org/jira/browse/HADOOP-9477
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.4-alpha
> Reporter: Kai Zheng
> Assignee: Dapeng Sun
> Fix For: 2.7.0
>
> Attachments: HADOOP-9477.003.patch, HADOOP-9477.004.patch,
> HADOOP-9477.005.patch, HADOOP-9477.patch, HADOOP-9477.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> It would be nice to support posixGroups for LdapGroupsMapping service. Below
> is from current description for the provider:
> hadoop.security.group.mapping.ldap.search.filter.group:
> An additional filter to use when searching for LDAP groups. This should be
> changed when resolving groups against a non-Active Directory installation.
> posixGroups are currently not a supported group class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
