[
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754149#comment-17754149
]
ASF GitHub Bot commented on HADOOP-18820:
-----------------------------------------
steveloughran commented on PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1677551297
HADOOP-18820. SDK v1 cut: S3AInternals
move "public" s3 client api calls out of S3AFS and into a new S3AInternals
interface which is implemented by a non-static inner class.
This
* has accessor method getS3AInternals()
* calls out that the methods are internal
* allows for future refactoring to move the implementation
out of s3a FileSystem class *completely*
* provides a home for any other low-level calls we want to make public
Issues from this
1. kept S3AFileSystem.getObjectMetadata() in s3a fs but tagged as deprecated.
Given that existing calls will all fail to link (new response class) I'm
thinking that
we can cut it.
> AWS SDK v2: make the v1 bridging support optional
> -------------------------------------------------
>
> Key: HADOOP-18820
> URL: https://issues.apache.org/jira/browse/HADOOP-18820
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> The AWS SDK v2 code includes the v1 sdk core for plugin support of
> * existing credential providers
> * delegation token binding
> I propose we break #2 and rely on those who have implemented to to upgrade.
> apart from all the needless changes the v2 SDK did to the api (why?) this is
> fairly straighforward
> for #1: fix through reflection, retaining a v1 sdk dependency at test time so
> we can verify that the binder works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
