[
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750300#comment-17750300
]
ASF GitHub Bot commented on HADOOP-18820:
-----------------------------------------
ahmarsuhail commented on code in PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#discussion_r1281774011
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -562,15 +563,65 @@ public static long dateToLong(final Date date) {
* @return instance of the specified class
* @throws IOException on any problem
*/
- @SuppressWarnings("unchecked")
- public static <InstanceT> InstanceT getInstanceFromReflection(Class<?>
instanceClass,
- Configuration conf, @Nullable URI uri, Class<?> interfaceImplemented,
String methodName,
+ public static <InstanceT> InstanceT getInstanceFromReflection(
Review Comment:
we can just get rid of this method? the only place it's used I think is
SignerFactory.createSigner(), which can also be updated to pass in
`signerClass.getName()` and use the new method
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/aws_sdk_upgrade.md:
##########
@@ -65,7 +201,7 @@ The s3 client is an instance of `S3Client` in V2 rather than
`AmazonS3`.
For this reason, the `S3ClientFactory` will be deprecated and replaced by one
that creates a V2
`S3Client`.
-The `getAmazonS3ClientForTesting()` method will also be updated to return the
`S3Client`.
+The `getAmazonS3ClientForTesting()` method has been updated to return the
`S3Client`.
### Signers
Review Comment:
do you think it's worth mentioning there's no sigV2 right now?
> AWS SDK v2: make the v1 bridging support optional
> -------------------------------------------------
>
> Key: HADOOP-18820
> URL: https://issues.apache.org/jira/browse/HADOOP-18820
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> The AWS SDK v2 code includes the v1 sdk core for plugin support of
> * existing credential providers
> * delegation token binding
> I propose we break #2 and rely on those who have implemented to to upgrade.
> apart from all the needless changes the v2 SDK did to the api (why?) this is
> fairly straighforward
> for #1: fix through reflection, retaining a v1 sdk dependency at test time so
> we can verify that the binder works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
