[
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750750#comment-17750750
]
ASF GitHub Bot commented on HADOOP-18820:
-----------------------------------------
steveloughran commented on code in PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#discussion_r1283235604
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/aws_sdk_upgrade.md:
##########
@@ -65,7 +201,7 @@ The s3 client is an instance of `S3Client` in V2 rather than
`AmazonS3`.
For this reason, the `S3ClientFactory` will be deprecated and replaced by one
that creates a V2
`S3Client`.
-The `getAmazonS3ClientForTesting()` method will also be updated to return the
`S3Client`.
+The `getAmazonS3ClientForTesting()` method has been updated to return the
`S3Client`.
### Signers
Review Comment:
will do.
Also, I'm thinking of renaming this method S3ClientV2ForTesting(). Why so?
you get a more meaningful "no such method" error rather than one about
signature mismatch
> AWS SDK v2: make the v1 bridging support optional
> -------------------------------------------------
>
> Key: HADOOP-18820
> URL: https://issues.apache.org/jira/browse/HADOOP-18820
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> The AWS SDK v2 code includes the v1 sdk core for plugin support of
> * existing credential providers
> * delegation token binding
> I propose we break #2 and rely on those who have implemented to to upgrade.
> apart from all the needless changes the v2 SDK did to the api (why?) this is
> fairly straighforward
> for #1: fix through reflection, retaining a v1 sdk dependency at test time so
> we can verify that the binder works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
