[
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755568#comment-17755568
]
ASF GitHub Bot commented on HADOOP-18820:
-----------------------------------------
steveloughran commented on code in PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#discussion_r1297276732
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/V2Migration.java:
##########
@@ -28,83 +28,47 @@
/**
* This class provides utility methods required for migrating S3A to AWS Java
SDK V2.
* For more information on the upgrade, see HADOOP-18073.
+ *
+ * <p>in HADOOP-18382. Upgrade AWS SDK to V2 - Prerequisites,
+ * this class contained a series of `LogExactlyOnce` loggers to warn on
+ * the first use of a feature which would change incompatibly; this shipped in
Hadoop 3.3.5.
+ * <p>
+ * With the move to v2 completed, attempts to use the v1 classes, will fail
+ * -except for the special case of support for v1 credential providers.
+ * <p>
+ * The warning methods are still present, where appropriate, but downgraded to
debug
+ * and only retained for debugging migration issues.
*/
public final class V2Migration {
private V2Migration() { }
public static final Logger SDK_V2_UPGRADE_LOG =
LoggerFactory.getLogger(SDK_V2_UPGRADE_LOG_NAME);
- private static final LogExactlyOnce WARN_ON_DELEGATION_TOKENS =
- new LogExactlyOnce(SDK_V2_UPGRADE_LOG);
-
- private static final LogExactlyOnce WARN_ON_GET_S3_CLIENT =
- new LogExactlyOnce(SDK_V2_UPGRADE_LOG);
-
private static final LogExactlyOnce
WARN_OF_DIRECTLY_REFERENCED_CREDENTIAL_PROVIDER =
new LogExactlyOnce(SDK_V2_UPGRADE_LOG);
- private static final LogExactlyOnce WARN_OF_CUSTOM_SIGNER =
- new LogExactlyOnce(SDK_V2_UPGRADE_LOG);
-
private static final LogExactlyOnce WARN_OF_REQUEST_HANDLERS =
new LogExactlyOnce(SDK_V2_UPGRADE_LOG);
- private static final LogExactlyOnce WARN_ON_GET_OBJECT_METADATA =
- new LogExactlyOnce(SDK_V2_UPGRADE_LOG);
-
/**
- * Warns on an AWS V1 credential provider being referenced directly.
+ * Notes an AWS V1 credential provider being referenced directly.
* @param name name of the credential provider
*/
public static void v1ProviderReferenced(String name) {
Review Comment:
i'll look at this
> AWS SDK v2: make the v1 bridging support optional
> -------------------------------------------------
>
> Key: HADOOP-18820
> URL: https://issues.apache.org/jira/browse/HADOOP-18820
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> The AWS SDK v2 code includes the v1 sdk core for plugin support of
> * existing credential providers
> * delegation token binding
> I propose we break #2 and rely on those who have implemented to to upgrade.
> apart from all the needless changes the v2 SDK did to the api (why?) this is
> fairly straighforward
> for #1: fix through reflection, retaining a v1 sdk dependency at test time so
> we can verify that the binder works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
