omalley commented on code in PR #4584:
URL: https://github.com/apache/hadoop/pull/4584#discussion_r936905717
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java:
##########
@@ -37,7 +37,9 @@ private RpcConstants() {
public static final int INVALID_RETRY_COUNT = -1;
-
+ // Special state ID value to indicate client request header has
routerFederatedState set.
+ public static final long REQUEST_HEADER_NAMESPACE_STATEIDS_SET = -2L;
Review Comment:
I think I'd rather have this constant be added along with the usage rather
than preemptively.
##########
hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto:
##########
@@ -157,6 +158,11 @@ message RpcResponseHeaderProto {
optional bytes clientId = 7; // Globally unique client ID
optional sint32 retryCount = 8 [default = -1];
optional int64 stateId = 9; // The last written Global State ID
+ optional bytes routerFederatedState = 10; // Alignment context info for use
with routers.
+}
+
+message RouterFederatedStateProto {
Review Comment:
I think this should not be here and should be an implementation detail in
RBF.
##########
hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto:
##########
@@ -91,6 +91,7 @@ message RpcRequestHeaderProto { // the header for the
RpcRequest
optional RPCTraceInfoProto traceInfo = 6; // tracing info
optional RPCCallerContextProto callerContext = 7; // call context
optional int64 stateId = 8; // The last seen Global State ID
+ optional bytes routerFederatedState = 9; // Alignment context info for use
with routers.
Review Comment:
I think you should add a comment here that says that the bytes should not be
interpreted by the client and should only be come from
RpcResponseHeaderProto.routerFederatedState.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
