simbadzina commented on code in PR #4584:
URL: https://github.com/apache/hadoop/pull/4584#discussion_r931470957
##########
hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto:
##########
@@ -157,6 +158,7 @@ message RpcResponseHeaderProto {
optional bytes clientId = 7; // Globally unique client ID
optional sint32 retryCount = 8 [default = -1];
optional int64 stateId = 9; // The last written Global State ID
+ map<string, int64> nameserviceStateIds = 10; // Last seen state IDs for
multiple nameservices.
Review Comment:
Yes, it should be optional. Thanks for spotting the error. I'll fix that.
I'm also going to make this a bytearray since the client doesn't need to
parse it. This will give us the flexibility to evolve the contents in the
routers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
